feat: rename sendUserAttributeVerificationCode #3759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnys1
reviewed
Sep 19, 2023
| ); | ||
|
|
||
| @Deprecated('Use sendUserAttributeVerificationCode.') | ||
| Future<SendUserAttributeVerificationCodeResult> |
There was a problem hiding this comment.
Let's keep the types the same for this method to avoid breaking anyone using them
packages/auth/amplify_auth_cognito/example/integration_test/user_attributes_test.dart
Show resolved
Hide resolved
| required AuthUserAttributeKey userAttributeKey, | ||
| SendUserAttributeVerificationCodeOptions? options, | ||
| }) { | ||
| throw UnimplementedError( |
There was a problem hiding this comment.
To keep this non-breaking can we have the default impl call resend?
There was a problem hiding this comment.
How would this change be breaking? Maybe I am missing something.
| } | ||
|
|
||
| @Deprecated(_deprecatedMessage) | ||
| // ignore: public_member_api_docs |
| } | ||
|
|
||
| @Deprecated('Use CognitoSendUserAttributeVerificationCodePluginOptions') | ||
| // ignore: public_member_api_docs |
.../amplify_core/lib/src/types/auth/attribute/send_user_attribute_verification_code_result.dart
Show resolved
Hide resolved
Equartey
previously approved these changes
Sep 20, 2023
Jordan-Nelson
force-pushed
the
feat/rename-sendUserAttributeVerificationCode
branch
from
629019d to
74b749c
Compare
dnys1
approved these changes
Sep 25, 2023
Equartey
approved these changes
Oct 2, 2023
Jordan-Nelson
deleted the
feat/rename-sendUserAttributeVerificationCode
branch
Equartey
pushed a commit
that referenced
this pull request
Oct 26, 2023
* feat: rename sendUserAttributeVerificationCode * fix: include deprecated category API * chore: add test, docs updates
Equartey
added a commit
that referenced
this pull request
Oct 26, 2023
### Features - feat: rename sendUserAttributeVerificationCode ([#3759](#3759)) ### Fixes - fix(aft): Small fixes ([#3838](#3838)) - fix(analytics): allow nullable userProfile - fix(analytics): event client flush events to do not discard events from cache on auth exception ([#3999](#3999)) - fix(auth): use loadCredentials to check login state - fix(authenticator): Beta channel fixes ([#3835](#3835)) - fix(authenticator): fix validate before trim bug ([#3809](#3809)) - fix(authenticator): use getCurrentUser to check sign in state - fix(pub): ignore templates folder during analysis ([#4009](#4009)) - fix(smithy): defines Output type to fix beta tests ([#3963](#3963)) - fix: catch and log updateEndpoint error during configure ([#3985](#3985)) - fix: remove exception during token timeout ([#3939](#3939)) ### Breaking Changes - fix(smithy_aws)!: do not sign optional requests Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey
added a commit
that referenced
this pull request
Oct 26, 2023
### Features - feat: rename sendUserAttributeVerificationCode ([#3759](#3759)) ### Fixes - fix(aft): Small fixes ([#3838](#3838)) - fix(analytics): allow nullable userProfile - fix(analytics): event client flush events to do not discard events from cache on auth exception ([#3999](#3999)) - fix(auth): use loadCredentials to check login state - fix(authenticator): Beta channel fixes ([#3835](#3835)) - fix(authenticator): fix validate before trim bug ([#3809](#3809)) - fix(authenticator): use getCurrentUser to check sign in state - fix(pub): ignore templates folder during analysis ([#4009](#4009)) - fix(smithy): defines Output type to fix beta tests ([#3963](#3963)) - fix: catch and log updateEndpoint error during configure ([#3985](#3985)) - fix: remove exception during token timeout ([#3939](#3939)) ### Breaking Changes - fix(smithy_aws)!: do not sign optional requests Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey
pushed a commit
that referenced
this pull request
Oct 30, 2023
* feat: rename sendUserAttributeVerificationCode * fix: include deprecated category API * chore: add test, docs updates
Equartey
added a commit
that referenced
this pull request
Oct 30, 2023
### Features - feat: rename sendUserAttributeVerificationCode ([#3759](#3759)) ### Fixes - fix(aft): Small fixes ([#3838](#3838)) - fix(analytics): allow nullable userProfile - fix(analytics): event client flush events to do not discard events from cache on auth exception ([#3999](#3999)) - fix(auth): use loadCredentials to check login state - fix(authenticator): Beta channel fixes ([#3835](#3835)) - fix(authenticator): fix validate before trim bug ([#3809](#3809)) - fix(authenticator): use getCurrentUser to check sign in state - fix(pub): ignore templates folder during analysis ([#4009](#4009)) - fix(smithy): defines Output type to fix beta tests ([#3963](#3963)) - fix: catch and log updateEndpoint error during configure ([#3985](#3985)) - fix: remove exception during token timeout ([#3939](#3939)) ### Breaking Changes - fix(smithy_aws)!: do not sign optional requests Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey
added a commit
that referenced
this pull request
Oct 30, 2023
- feat: rename sendUserAttributeVerificationCode ([#3759](#3759)) - fix(aft): Small fixes ([#3838](#3838)) - fix(analytics): allow nullable userProfile - fix(analytics): event client flush events to do not discard events from cache on auth exception ([#3999](#3999)) - fix(auth): use loadCredentials to check login state - fix(authenticator): Beta channel fixes ([#3835](#3835)) - fix(authenticator): fix validate before trim bug ([#3809](#3809)) - fix(authenticator): use getCurrentUser to check sign in state - fix(pub): ignore templates folder during analysis ([#4009](#4009)) - fix(smithy): defines Output type to fix beta tests ([#3963](#3963)) - fix: catch and log updateEndpoint error during configure ([#3985](#3985)) - fix: remove exception during token timeout ([#3939](#3939)) - fix(smithy_aws)!: do not sign optional requests Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey
added a commit
that referenced
this pull request
Nov 6, 2023
* chore(version): Bump version - feat: rename sendUserAttributeVerificationCode ([#3759](#3759)) - fix(aft): Small fixes ([#3838](#3838)) - fix(analytics): allow nullable userProfile - fix(analytics): event client flush events to do not discard events from cache on auth exception ([#3999](#3999)) - fix(auth): use loadCredentials to check login state - fix(authenticator): Beta channel fixes ([#3835](#3835)) - fix(authenticator): fix validate before trim bug ([#3809](#3809)) - fix(authenticator): use getCurrentUser to check sign in state - fix(pub): ignore templates folder during analysis ([#4009](#4009)) - fix(smithy): defines Output type to fix beta tests ([#3963](#3963)) - fix: catch and log updateEndpoint error during configure ([#3985](#3985)) - fix: remove exception during token timeout ([#3939](#3939)) - fix(smithy_aws)!: do not sign optional requests Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee * fix: slide smithy_codegen window * fix: added drop dep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #3756
Description of changes:
sendUserAttributeVerificationCodeand associated classes in place ofresendUserAttributeConfirmationCoderesendUserAttributeConfirmationCodeand associated classesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.